add golangci-lint

.github/workflows/verify.yml

@@ -39,6 +39,11 @@ jobs:
         with:
           go-version-file: go.mod
           cache: true
+      - id: lint
+        name: Lint Go Code
+        uses: golangci/golangci-lint-action@v3
+        with:
+          version: latest
       - id: generate_docs
         name: Generate Documentation
         run: go generate

.golangci.yml

@@ -0,0 +1,6 @@
+# SPDX-FileCopyrightText: The terraform-provider-git Authors
+# SPDX-License-Identifier: 0BSD
+
+run:
+  build-tags:
+    - testing

dev/Containerfile

@@ -5,3 +5,4 @@ FROM metio/devcontainers-go:latest
 
 RUN go install github.com/hashicorp/terraform@main
 RUN go install gotest.tools/gotestsum@latest
+RUN go install github.com/golangci/golangci-lint/cmd/golangci-lint@master

internal/provider/data_source_git_log.go

@@ -203,6 +203,13 @@ func (r *dataSourceGitLog) Read(ctx context.Context, req datasource.ReadRequest,
 		}
 		return nil
 	})
+	if err != nil {
+		resp.Diagnostics.AddError(
+			"Cannot read commits",
+			"Could not read commits because of: "+err.Error(),
+		)
+		return
+	}
 	if !inputs.Skip.IsNull() && !inputs.Skip.IsUnknown() {
 		if int64(len(hashes)) >= inputs.Skip.Value {
 			hashes = hashes[inputs.Skip.Value:]

internal/provider/resource_git_commit_test.go

@@ -112,11 +112,11 @@ func TestResourceGitCommit_Directory_Missing(t *testing.T) {
 		ProtoV6ProviderFactories: testutils.ProviderFactories(),
 		Steps: []resource.TestStep{
 			{
-				Config: fmt.Sprintf(`
+				Config: `
 					resource "git_commit" "test" {
 						message = "committed with terraform"
 					}
-				`),
+				`,
 				ExpectError: regexp.MustCompile(`Missing required argument`),
 			},
 		},

internal/provider/resource_git_init_test.go

@@ -110,7 +110,7 @@ func TestResourceGitInit_Import(t *testing.T) {
 			{
 				ResourceName:      "git_init.test",
 				ImportState:       true,
-				ImportStateId:     fmt.Sprintf("%s", directory),
+				ImportStateId:     directory,
 				ImportStateVerify: true,
 			},
 		},

project.mk

@@ -44,6 +44,11 @@ out/go-format-sentinel: $(shell find . -type f -name '*.go')
 	gofmt -s -w -e .
 	touch $@
 
+out/go-lint-sentinel: $(shell find . -type f -name '*.go')
+	mkdir --parents $(@D)
+	golangci-lint run
+	touch $@
+
 out/tf-format-sentinel: $(shell find ./examples -type f -name '*.tf') $(shell find ./terratest -type f -name '*.tf')
 	mkdir --parents $(@D)
 	terraform fmt -recursive ./terratest
@@ -73,6 +78,9 @@ test: ## run specific unit tests
 .PHONY: format
 format: out/go-format-sentinel out/tf-format-sentinel ## format Go code and Terraform config
 
+.PHONY: lint
+lint: out/go-lint-sentinel ## lint all Go code
+
 .PHONY: update
 update: ## update all dependencies
 	go get -u