Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit: remove errors before removing variables. #2061

Merged
merged 1 commit into from
Mar 13, 2017
Merged

edit: remove errors before removing variables. #2061

merged 1 commit into from
Mar 13, 2017

Conversation

oliver-sanders
Copy link
Member

Closes #406

@oliver-sanders oliver-sanders added this to the next-release milestone Mar 8, 2017
@matthewrmshin
Copy link
Member

(Even though the change looks absolutely trivial, I think it is worth a second pair of eyes, since we don't have automatic tests for the GUI.)

arjclark
arjclark approved these changes Mar 13, 2017
View reviewed changes
Copy link
Contributor

@arjclark arjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Tested manually as working with example from #406 + a quick subset of the demo metadata examples.

@arjclark arjclark merged commit dd5d2c3 into metomi:master Mar 13, 2017
@oliver-sanders oliver-sanders deleted the 406.edit-remove-trigger-state-variable-error-ith-variable branch May 18, 2018 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjclark arjclark arjclark approved these changes

@matthewrmshin matthewrmshin matthewrmshin approved these changes

Assignees

@matthewrmshin matthewrmshin

@arjclark arjclark

@oliver-sanders oliver-sanders

Labels
bug
Projects
None yet
Milestone
2017.05.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oliver-sanders @matthewrmshin @arjclark