Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add line number offset functionality #257

Merged
merged 2 commits into from
Jan 1, 2023
Merged

add line number offset functionality #257

merged 2 commits into from
Jan 1, 2023

Conversation

pjebs
Copy link
Contributor

@pjebs pjebs commented Dec 31, 2022

No description provided.

@pjebs pjebs mentioned this pull request Dec 31, 2022
Closed
metonym
metonym reviewed Dec 31, 2022
View reviewed changes
Copy link
Owner

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to submit a PR.

Can the prop name be more descriptive, like startingLineNumber?

@pjebs
Copy link
Contributor Author

pjebs commented Dec 31, 2022

@metonym done

metonym
metonym approved these changes Jan 1, 2023
View reviewed changes
Copy link
Owner

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@metonym metonym merged commit 41f1665 into metonym:master Jan 1, 2023
@metonym
Copy link
Owner

metonym commented Jan 1, 2023

Released in v7.1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metonym metonym metonym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjebs @metonym