Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update threshold type to match spec #70

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Update threshold type to match spec #70

merged 2 commits into from
Jul 20, 2023

Conversation

kevinkace
Copy link
Contributor

The threshold can also be an array of numbers:
https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API#threshold

The threshold attr is passed to the IntersectionObserver constructor untouched see here, so this already works, eg:
https://svelte.dev/repl/8678c81cba1142aa8b788bb5dd991968?version=4.1.0

Copy link
Owner

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and for providing an example.

@metonym metonym merged commit 6992399 into metonym:master Jul 20, 2023
@metonym
Copy link
Owner

metonym commented Jul 20, 2023

Fixed in v0.10.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants