#37 decode int? on cljs different from clj #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikitommi
requested changes
May 4, 2020
| @@ -82,7 +82,9 @@ | |||
| (if (string? x) | |||
| (try | |||
| #?(:clj (Long/parseLong x) | |||
| :cljs (let [x' (js/parseInt x 10)] | |||
| :cljs (let [x' (if (re-find #"\D" (subs x 1)) | |||
There was a problem hiding this comment.
I think it would be better to use js/Number here, and test the result with js/Number.isInteger.
There was a problem hiding this comment.
Would guess the performance is better but also the number logic stays elsewhere. What do you think.
There was a problem hiding this comment.
After making the pull. I've tried isFinite to get rid of the re-find. But I've abandoned because it let numbers like '2e2' pass. And it's not on par with clojure's parseLong. Number/isInteger suffers from the same problem. Number('2e2') = 200 . We would be in a better position than today, but not on par with clojure.
|
thanks!! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javascript parseInt is lenient with "+1-2" "1abc" resulting integer one.
Long/parseLong recognizes the sign at the start of the string.
So I've made a \D expression ignoring the first character and return ##Nan if it's found.
Just to be more like clojure. I think we can do this because we are parsing base 10 numbers.
The if string? already guards for string so its safe to call subs and re-find.