Set JSON Schema types and formats for numbers properly #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Note that number formats aren't mentioned in JSON Schema spec, but are from OpenAPI spec. - Comparators shouldn't automatically set format to double. - Set format double for :double and double?. - decimal? is BigDecimal, so that is not a double. - Fix rational? type to number, double isn't valid type - Fix ratio? type to number, ratios aren't integers.
Deraen
force-pushed
the
json-schema-number-formats
branch
2 times, most recently
from
c6bcafa
to
727c58f
Compare
Deraen
force-pushed
the
json-schema-number-formats
branch
from
727c58f
to
91cd37a
Compare
ikitommi
approved these changes
Jan 26, 2021
| @@ -105,7 +105,8 @@ | |||
| (merge {:type "integer"} (-> schema m/properties (select-keys [:min :max]) (set/rename-keys {:min :minimum, :max :maximum})))) | |||
|
|
|||
| (defmethod accept :double [_ schema _ _] | |||
| (merge {:type "number"} (-> schema m/properties (select-keys [:min :max]) (set/rename-keys {:min :minimum, :max :maximum})))) | |||
| (merge {:type "number"} | |||
| (-> schema m/properties (select-keys [:min :max]) (set/rename-keys {:min :minimum, :max :maximum})))) | |||
There was a problem hiding this comment.
thks could be a helper in json-schema as it's now copied 3 times already.
|
|
||
| (defmethod accept :int [_ schema _ _] | ||
| (merge {:type "integer" :format "int64"} | ||
| (-> schema m/properties (select-keys [:min :max]) (set/rename-keys {:min :minimum, :max :maximum})))) |
There was a problem hiding this comment.
Just double-check: is this inclusive or exclusive? Json schema separates the two.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from OpenAPI spec.