Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: standardized CLI #193

Merged
merged 1 commit into from
Dec 11, 2024
Merged

feat: standardized CLI #193

merged 1 commit into from
Dec 11, 2024

Conversation

devmaxde
Copy link
Contributor

@devmaxde devmaxde commented Sep 9, 2024 •
edited
Loading

Moved the Standardized CLI Params from the metrics-tools package to the Python Package.

@devmaxde devmaxde marked this pull request as draft October 1, 2024 12:09
@devmaxde devmaxde force-pushed the 188-standardized-cli branch 5 times, most recently from a808949 to 1b53019 Compare October 1, 2024 14:57
@devmaxde devmaxde force-pushed the 188-standardized-cli branch from 9f964b4 to 5e1649b Compare October 2, 2024 11:53
@devmaxde devmaxde self-assigned this Oct 2, 2024
@devmaxde devmaxde force-pushed the 188-standardized-cli branch from af62814 to 5e1649b Compare October 15, 2024 09:38
@devmaxde devmaxde marked this pull request as ready for review October 15, 2024 10:39
@devmaxde devmaxde linked an issue Oct 15, 2024 that may be closed by this pull request
Add click command for standardized CLI parameters #188
Closed
7 tasks
bmario
bmario requested changes Oct 16, 2024
View reviewed changes
examples/metricq_client.py Outdated Show resolved Hide resolved
metricq/cli/params.py Outdated Show resolved Hide resolved
metricq/cli/wrapper.py Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
@devmaxde devmaxde force-pushed the 188-standardized-cli branch 5 times, most recently from a247a39 to 8c9b7b6 Compare October 17, 2024 11:07
bmario
bmario reviewed Oct 17, 2024
View reviewed changes
metricq/cli/wrapper.py Outdated Show resolved Hide resolved
@devmaxde devmaxde force-pushed the 188-standardized-cli branch from bdfd663 to c895f86 Compare October 17, 2024 12:34
bmario
bmario requested changes Oct 18, 2024
View reviewed changes
examples/metricq_synchronous_source.py Outdated Show resolved Hide resolved
metricq/cli/__init__.py Show resolved Hide resolved
examples/metricq_sink.py Outdated Show resolved Hide resolved
metricq/cli/wrapper.py Outdated Show resolved Hide resolved
@devmaxde devmaxde force-pushed the 188-standardized-cli branch from 533d371 to 6893374 Compare October 22, 2024 11:54
bmario
bmario requested changes Oct 22, 2024
View reviewed changes
examples/metricq_sink.py Show resolved Hide resolved
@devmaxde devmaxde force-pushed the 188-standardized-cli branch 2 times, most recently from c214807 to 8c7bdd9 Compare October 29, 2024 11:01
bmario
bmario requested changes Oct 29, 2024
View reviewed changes
metricq/cli/wrapper.py Outdated Show resolved Hide resolved
metricq/cli/wrapper.py Outdated Show resolved Hide resolved
metricq/cli/wrapper.py Outdated Show resolved Hide resolved
@devmaxde devmaxde force-pushed the 188-standardized-cli branch from 8c7bdd9 to 97cd0a2 Compare October 29, 2024 12:58
bmario
bmario requested changes Nov 5, 2024
View reviewed changes
Copy link
Member

@bmario bmario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that there is no documentation for this. Please extend the sphinx documentation and comments at the functions classes such that they will be picked up in the API reference. Also, mention the extra dependency thing metricq[cli].

@devmaxde devmaxde force-pushed the 188-standardized-cli branch from 97cd0a2 to 3bf423a Compare November 5, 2024 14:52
@devmaxde devmaxde force-pushed the 188-standardized-cli branch from 3bf423a to 497bd92 Compare November 12, 2024 12:31
bmario
bmario requested changes Nov 13, 2024
View reviewed changes
examples/metricq_synchronous_source.py Outdated Show resolved Hide resolved
docs/api/cli.rst Outdated Show resolved Hide resolved
docs/api/cli.rst Outdated Show resolved Hide resolved
docs/api/cli.rst Outdated Show resolved Hide resolved
docs/api/cli.rst Outdated Show resolved Hide resolved
docs/api/cli.rst Outdated Show resolved Hide resolved
@devmaxde devmaxde force-pushed the 188-standardized-cli branch 8 times, most recently from 187e061 to d6b638b Compare December 10, 2024 13:41
@devmaxde devmaxde force-pushed the 188-standardized-cli branch from d6b638b to dbbebca Compare December 11, 2024 14:00
@devmaxde devmaxde force-pushed the 188-standardized-cli branch from dbbebca to 581d3ff Compare December 11, 2024 15:01
@bmario bmario merged commit 90bdf36 into master Dec 11, 2024
12 checks passed
@bmario bmario deleted the 188-standardized-cli branch December 11, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmario bmario bmario approved these changes

Assignees

@devmaxde devmaxde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add click command for standardized CLI parameters
2 participants
@devmaxde @bmario