Allow passing owned strings as metric key. #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobz
added
C-core
|
CI breakage looks to be related to Alexhuszagh/rust-lexical#55 so I'm trying to get that sorted. |
mnpw
pushed a commit
to mnpw/metrics
that referenced
this pull request
Mar 8, 2024
…_key Allow passing owned strings as metric key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, due to the way the macros were written, users could specify a metric key as either a string literal or an expression that pointed to an owned string, due to the
Into<T>implementations forKeyand the way the macros handled the input arguments. While not an explicit design goal, this was broken in the rewrite for 0.13: #165This PR reworks the macros such that they can properly handle either a string literal or owned string as the metric key. Minimal work was required on the
Key/KeyDataside as we mostly had a sufficient set offrom_*methods. The real work is in the macro argument parsing and code generation itself, dealing with the matrix of combinations: is the name static, are the labels static, and all the combinations in thereof.