Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

label.rs: Implemented inner reference trait for Label #470

Merged
merged 1 commit into from
Apr 12, 2024
Merged

label.rs: Implemented inner reference trait for Label #470

merged 1 commit into from
Apr 12, 2024

Conversation

jpds
Copy link
Contributor

@jpds jpds commented Apr 10, 2024

Fixes: #469

@jpds jpds force-pushed the inner-reference-impl-label branch from 9d4ca0b to 7e9ec12 Compare April 10, 2024 21:15
@jpds jpds force-pushed the inner-reference-impl-label branch from 7e9ec12 to 14ea2c1 Compare April 10, 2024 21:17
@tobz tobz added C-core Component: core functionality such as traits, etc. E-simple Effort: simple. T-enhancement Type: enhancement. T-ergonomics Type: ergonomics. labels Apr 11, 2024
tobz
tobz approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@tobz tobz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Ignoring the failed test run since it's related to MSRV shenanigans in some downstream dependency.

@tobz tobz merged commit 5f9750f into metrics-rs:main Apr 12, 2024
8 of 12 checks passed
@tobz tobz added the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label Apr 12, 2024
@tobz
Copy link
Member

tobz commented May 27, 2024

Released in metrics@v0.23.0.

Thanks again for your contribution. 🙏🏻

@tobz tobz removed the S-awaiting-release Status: awaiting a release to be considered fixed/implemented. label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobz tobz tobz approved these changes

Assignees
No one assigned
Labels
C-core Component: core functionality such as traits, etc. E-simple Effort: simple. T-enhancement Type: enhancement. T-ergonomics Type: ergonomics.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IntoLabels for BTreeMap<String, String>
2 participants
@jpds @tobz