-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing data chart type doesn't seem to obey full_width #399
Comments
Indeed, you're right. The missing chart type doesn't call the common |
…bide by full_width and full_height. Also added a test to verify that the missing chart does indeed satisfy the requirement. Also, changed the name on the data.htm page of the examples.
@almossawi @reanimus please take a look at most recent commit. Should in theory fix the bug, but am pretty tired and could use another set of eyes. New test passes, at least :) |
The line that updates the viewbox was missing, and I updated the left margin in |
Agreed! Chart works as intended now. :) |
Was just about to write an issue on this, glad to see it fixed so quickly! Also, +1 on a great library. |
First of all, kudos on this library, It's been a dream to use so far. I'm looking to include the pre-existing 'missing-data' type graphs when we've got insufficient data, but there's a slight annoyance in the way it's rendered at the moment. All of our graphs are set to use full width, but when the graph is a missing data graph, it doesn't fill in horizontal space. It looks like this:
Am I doing something wrong here? For reference, these are the options being used:
The text was updated successfully, but these errors were encountered: