Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend x-axis ticks when working with dates #489

Closed
hamilton opened this issue Sep 8, 2015 · 4 comments
Closed

extend x-axis ticks when working with dates #489

hamilton opened this issue Sep 8, 2015 · 4 comments
Milestone

Comments

@hamilton
Copy link
Collaborator

hamilton commented Sep 8, 2015

The current method for drawing the x-axis ticks when the x accessor targets dates often leaves big gaps between the axis and the left margin. This confuses users and is inelegant. We have a few stopgaps to ameliorate the design issue, but we have decided that it simply makes more sense to extend the x-axis ticks past the range of the line, so that we 1.) get the same design effect, and 2.) remove any chance of too-short axes.

This will effectively solve a few other issues: #458, #456.

@almossawi
Copy link
Contributor

@hamilton See what you think of this last commit. xax_not_compact is on by default for now. The examples don't look too bad.

@hamilton
Copy link
Collaborator Author

looks good to me.

@almossawi
Copy link
Contributor

Renamed the option to axes_not_compact. MG will transition uses of xax_start_at_min to axes_not_compact starting in v2.7. It's on by default for now. Feel free to change that if you have a strong preference for the original one.

@almossawi
Copy link
Contributor

Trying to consolidate all issues to do with axes and min, max values. It looks like we can keep track of this in #456, so I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants