Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make title a text element in the SVG #504

Closed
amlwwalker opened this issue Oct 10, 2015 · 4 comments
Closed

Make title a text element in the SVG #504

amlwwalker opened this issue Oct 10, 2015 · 4 comments
Milestone

Comments

@amlwwalker
Copy link

Its a bit annoying that the title of the chart is an h2 element above the chart. If you look at libraries like http://maurizzzio.github.io/function-plot/ the title is part of the SVG. This means that if you copy the SVG contents (or in my case create a "Download SVG" button) you get the title with it.

In my opinion it would be better anyway if the title was part of the SVG.

@hamilton
Copy link
Collaborator

Sorry that you find this annoying. We have on our roadmap a plan to convert the title to SVG.

@hamilton hamilton added this to the v2.7 milestone Oct 13, 2015
@almossawi almossawi self-assigned this Oct 19, 2015
almossawi added a commit that referenced this issue Oct 20, 2015
@almossawi
Copy link
Contributor

I've made a start on this. The title is now part of the SVG container, and the popover works as before. This also resolves the issue with titles sometimes appearing horizontally misaligned due to a large left margin.

@almossawi
Copy link
Contributor

All done. @hamilton Let me know if you notice any issues. I also changed the y-position of mg-active-datapoint so that it's always slightly above the plot area rather than midway between the top edge and the plot area.

almossawi added a commit that referenced this issue Oct 20, 2015
@amlwwalker
Copy link
Author

nice guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants