Skip to content

Commit

Permalink
test: skips vdiffr tests on CRAN. This is mainly so that we can run `…
Browse files Browse the repository at this point in the history
…devtools::check(env_vars = c(NOT_CRAN = "false"))` to be able to check everything else, but _not_ run the vdiffr tests, because they fail in `devtools::check()`.

We tried debugging some of these failures but, per this comment from Hadley r-lib/devtools#2258 (comment) , it has is very difficult and is a clear drawback of vdiffr. That said, the tests pass with devtools::test() and serve their purpose of ensuring future development doesn't break existing functionality. For this reason, we are moving forward with this approach for now.
  • Loading branch information
seth127 committed Feb 9, 2022
1 parent 957aff1 commit 223e8f6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions tests/testthat/test-base-plot.R
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
skip_on_cran() # vdiffr flakiness

dataDir <- system.file("test-data", package = "pmforest")
specDir <- file.path(dataDir, "spec")
Expand Down
1 change: 1 addition & 0 deletions tests/testthat/test-nsim-plot.R
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
skip_on_cran() # vdiffr flakiness

dataDir <- system.file("test-data", package = "pmforest")
specDir <- file.path(dataDir, "spec")
Expand Down

0 comments on commit 223e8f6

Please sign in to comment.