Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

https://github.com/meveo-org/meveo/issues/693 #707

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

https://github.com/meveo-org/meveo/issues/693 #707

wants to merge 2 commits into from

Conversation

fmunir1153
Copy link
Collaborator

No description provided.

@fmunir1153 fmunir1153 requested a review from ClementBareth April 4, 2023 15:33
@fmunir1153 fmunir1153 self-assigned this Apr 4, 2023
@fmunir1153 fmunir1153 requested a review from smichea April 4, 2023 15:34
smichea
smichea reviewed Apr 5, 2023
View reviewed changes
Copy link
Contributor

@smichea smichea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try using it for a CET that has 2 binary CFT ?
I guess the hardcoded id="wrapper" wont allow to use the component more than once

@fmunir1153
Copy link
Collaborator Author

I will remove id, as just using @parent will not cause problem, there should ne no need to use id.

@fmunir1153
Copy link
Collaborator Author

Pull request has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smichea smichea smichea left review comments

@ClementBareth ClementBareth Awaiting requested review from ClementBareth

At least 1 approving review is required to merge this pull request.

Assignees

@fmunir1153 fmunir1153

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fmunir1153 @smichea