Added adapter.exists(fileName) #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears this fails under node 4 and 5, as F_OK does not exist. I'll look for an alternative. |
|
Fixed by applying a fix seen in nodejs/node#8044. |
|
Thanks for the PR! This seems like a good addition, and the code looks flawless as well. Merging. |
|
I just published v1.0.0, which also includes this addition. Thanks again for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
adapter.exists(fileName)- a method to check whether or not a file exists. While this is not strictly necessary for reading, it can be particularly useful if you don't want to read a file but simply check if it is present in the adapter.Additionally, I added
.idea/to the.gitignore, as my IDE of choice (WebStorm) creates this directory and it should not be pushed to the repo.