Drop compatibility with callable response factories on MethodNotAllowedMiddleware and ImplicitOptionsMiddleware
#69
Conversation
gsteel
changed the title
MethodNotAllowedMiddlewareMethodNotAllowedMiddleware and ImplicitOptionsMiddleware
| if (! $container->has(ResponseFactoryInterface::class)) { | ||
| throw MissingDependencyException::dependencyForService( | ||
| ResponseFactoryInterface::class, | ||
| ImplicitOptionsMiddleware::class, | ||
| ); | ||
| } |
There was a problem hiding this comment.
Do we really want to have this kind of exception handling in each factory?
Feels simpler to improve laminas/laminas-servicemanager to better inspect traces, perhaps?
There was a problem hiding this comment.
I actually think that the traces are already easy enough to figure out, without this kind of specific exception, but I was just following convention here and didn't think it was worth breaking BC with documented @throws
There was a problem hiding this comment.
Works for me, it's just something we should perhaps improve in upstream, by rendering better traces in exceptions in a future iteration.
We can decide to drop them overall from this component in a later patch: the redundant ->has() calls all add up quickly, if every service needs to do them
…wedMiddleware` Signed-off-by: George Steel <george@net-glue.co.uk>
…are` Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
force-pushed
the
v4/method-not-allowed-response-factory
branch
from
82ab78e to
567cc25
Compare
Description
ResponseFactoryInterfaceCallableResponseFactoryDecorator