Deprecate custom code_action method

[mfussenegger]

With neovim 0.6 it is possible to use the built-in
vim.lsp.buf.code_action function and still have all extensions from
jdtls work.

[axieax]

With neovim 0.6 it is possible to use the built-in vim.lsp.buf.code_action function and still have all extensions from jdtls work.

Hi will Telescope lsp_code_actions be supported as well? Although the code action options appear, using some (such as toString) displays the following error:
jdt.ls: -32601: No delegateCommandHandler for java.action.generateToStringPrompt

[mfussenegger]

No telescope implements their own code-action (and from a quick look it looks incomplete and does some stuff that hasn't been necessary for a long time)

But it looks like you could use https://github.com/nvim-telescope/telescope-ui-select.nvim so that the built-in vim.lsp.buf.code_action will use telescope for the selection

[axieax]

Oh I see.. I didn't realise Telescope did their own thing ahaha
I usually use https://github.com/weilbith/nvim-code-action-menu to get code action previews for most other languages and thought nvim-jdtls could integrate with it the same way since vim.lsp.buf.code_action is now supported. Not sure if this is possible tho 🤔

[mfussenegger]

nvim-code-action-menu also re-implements the code-action functionality from scratch and is incomplete. It doesn't support client side commands.

It's not that nvim-jdtls would have to integrate nvim-code-action-menu, it's that other plugins shouldn't re-implement the entire code-action functionality themselves - and if they do, they'd need to implement all of it. Which afaik currently none does.

That nvim-jdtls had its own code_action function was due to missing functionality/extension points in neovim, but all the missing bits got integrated into neovim 0.6

[axieax]

Fair enough, really appreciate the clarification!