Skip to content

Commit

Permalink
Don't set accessibilityRole by default in Flatlist (facebook#1382) (f…
Browse files Browse the repository at this point in the history
  • Loading branch information
chiuam authored Aug 25, 2022
1 parent 247f915 commit 369b313
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
1 change: 0 additions & 1 deletion Libraries/Lists/FlatList.js
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,6 @@ class FlatList<ItemT> extends React.PureComponent<Props<ItemT>, void> {
removeClippedSubviews={removeClippedSubviewsOrDefault(
_removeClippedSubviews,
)}
accessibilityRole="table" // TODO(macOS GH#774): Inherit NSAccessibilityTable protocols
{...this._renderer()}
/>
);
Expand Down
7 changes: 0 additions & 7 deletions Libraries/Lists/__tests__/__snapshots__/FlatList-test.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ exports[`FlatList renders all the bells and whistles 1`] = `
ListEmptyComponent={[Function]}
ListFooterComponent={[Function]}
ListHeaderComponent={[Function]}
accessibilityRole="table"
data={
Array [
Object {
Expand Down Expand Up @@ -122,7 +121,6 @@ exports[`FlatList renders all the bells and whistles 1`] = `

exports[`FlatList renders empty list 1`] = `
<RCTScrollView
accessibilityRole="table"
data={Array []}
getItem={[Function]}
getItemCount={[Function]}
Expand All @@ -146,7 +144,6 @@ exports[`FlatList renders empty list 1`] = `

exports[`FlatList renders null list 1`] = `
<RCTScrollView
accessibilityRole="table"
getItem={[Function]}
getItemCount={[Function]}
keyExtractor={[Function]}
Expand All @@ -169,7 +166,6 @@ exports[`FlatList renders null list 1`] = `

exports[`FlatList renders simple list (multiple columns) 1`] = `
<RCTScrollView
accessibilityRole="table"
data={
Array [
Object {
Expand Down Expand Up @@ -241,7 +237,6 @@ exports[`FlatList renders simple list (multiple columns) 1`] = `

exports[`FlatList renders simple list 1`] = `
<RCTScrollView
accessibilityRole="table"
data={
Array [
Object {
Expand Down Expand Up @@ -303,7 +298,6 @@ exports[`FlatList renders simple list 1`] = `
exports[`FlatList renders simple list using ListItemComponent (multiple columns) 1`] = `
<RCTScrollView
ListItemComponent={[Function]}
accessibilityRole="table"
data={
Array [
Object {
Expand Down Expand Up @@ -375,7 +369,6 @@ exports[`FlatList renders simple list using ListItemComponent (multiple columns)
exports[`FlatList renders simple list using ListItemComponent 1`] = `
<RCTScrollView
ListItemComponent={[Function]}
accessibilityRole="table"
data={
Array [
Object {
Expand Down

0 comments on commit 369b313

Please sign in to comment.