Restructuring dbnames

[kadrlica]

This PR is meant to allow access to decade. It originally sought to:

• Add decade to the list of allowed databases.
• To define the list of allowed databases in one place (Unique list of allowed dbnames #169)
  However, after some consideration, the restriction on database names was removed from the parser.

[mgckind]

can we merge this?

[mgckind]

want me to jump in? pinging @Michael-D-Johnson so he is aware of the conversation

[kadrlica]

I wasn't able to test (didn't have access yet). Also, I thought we might want to use this opportunity to centralize the list of databases.

[kadrlica]

More generally, why are we tracking the viable databases at all? Shouldn't the code just check the services file directly? If a database exists in the services file then try to connect, otherwise throw an exception?

[kadrlica]

If we don't restrict database names at the parser level, this is what we get:

Database entered is not in ['db-dessci', 'db-desdr', 'db-destest', 'db-desoper'] or in DES_SERVICE file, continue anyway [y]/n

Adding section db-test to DES_SERVICES file

Enter username : hello
Enter password : 

ORA-12514: TNS:listener does not currently know of service requested in connect descriptor

I'll add a bit more descriptive message.

[kadrlica]

@mgckind ok, I think this is ready to merge and tag.

[mgckind]

Thanks, will take a look

[kadrlica]

@mgckind we have a DELVE meeting on Friday. Do you think this new version could be live by then?

[mgckind]

yes, will do soon