feat(garageDoorOpener): initial attempt to support Novoferm ES423 with command ON/OFF instead of TOGGLE #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salut @mgcrea,
Suite à cette issue #143, j'ai commencé à regarder un peu comment je pouvais modifier le GarageDoorOpener pour supporter mes portes de garage Novoferm ES423 (qui ne comprennent pas l'instruction TOGGLE, mais réagissent aux commandes ON/OFF).
J'ai fait un build custom et tester dans Homebridge, cela fonctionne plutôt pas mal.
Je n'ai pas trop d'idée sur comment intégrer ça autrement, garder le support TOGGLE pour ceux chez qui ça fonctionne et ajouter le ON/OFF pour les autres (comme moi).
PR créé pour ouvrir la discussion :)
Ce qui fonctionne chez moi: