Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Improve sortables detection #1151

Merged
merged 5 commits into from
Dec 2, 2024
Merged

chore: Improve sortables detection #1151

merged 5 commits into from
Dec 2, 2024

Conversation

denisvmedia
Copy link
Collaborator

@denisvmedia denisvmedia commented Nov 30, 2024 •
edited
Loading

This PR resolves TODO comment that proposed to check sortable methods signatures.

  • Ensures that only methods with the correct signature are identified as implementing required behavior (sort.Interface).
  • Prevents accidental false positives from methods that happen to have the same name but differ in their functionality.

@denisvmedia denisvmedia force-pushed the improve-sortable-detection branch from 2a3720d to fa1efd1 Compare November 30, 2024 09:41
@chavacava
Copy link
Collaborator

Hi @denisvmedia thanks for the PR. I've did some refactoring, please check my commits

@denisvmedia
Copy link
Collaborator Author

It's a new approach :) Better than mine. LGTM. Let's merge it.

@chavacava chavacava merged commit cb74ccb into master Dec 2, 2024
5 checks passed
@denisvmedia denisvmedia deleted the improve-sortable-detection branch December 2, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chavacava chavacava Awaiting requested review from chavacava

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@denisvmedia @chavacava