Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sarif.go #773

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Update sarif.go #773

merged 1 commit into from
Nov 11, 2022

Conversation

rnikoopour
Copy link
Contributor

@rnikoopour rnikoopour commented Nov 9, 2022

This PR solves #771. Removing the subtraction when setting the line and column numbers resolves the off by one issue.

Added Tests: No

Code Follows Style: Yes

Closes #771

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@chavacava chavacava merged commit ae282a5 into mgechev:master Nov 11, 2022
@chavacava
Copy link
Collaborator

Hi @rnikoopour, thanks for filling the issue and providing a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SARIF mode line and column numbers off by 1
2 participants