empty-block: Fix false positive on select {} #805
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a false positive reported by revive on the following:
This is a way to block the program indefinitely.
It is used in cases like:
Running a long-running server in a background thread
and blocking
main
from exiting until the application dies.This is something you might do if your process has
multiple servers/listeners in the same process.
In programs compiled to WASM to prevent the application from exiting,
so that the Javascript components may interact with it.
Without this, one may see an error like,
"Error: Go program has already exited"
As a workaround, these programs can block forever
by receiving from a throwaway channel (
<-make(chan struct{})
),but
select {}
is still a completely valid way of doing this,so supporting it makes sense.
The issue was previously reported in #698 but was closed
because the author was satisfied with a
//nolint
comment.Now that this rule is part of the default rule set (#799)
the case for addressing the false positive is stronger.
Resolves #804