Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOError if MANIFEST.in is missing #32

Closed
mgedmin opened this issue Oct 1, 2014 · 0 comments
Closed

IOError if MANIFEST.in is missing #32

mgedmin opened this issue Oct 1, 2014 · 0 comments

Comments

@mgedmin
Copy link
Owner

mgedmin commented Oct 1, 2014

  1. Get a git repo that has a MANIFEST.in, e.g. check-manifest's own repo
  2. rm MANIFEST.in (but don't git rm)
  3. Run check-manifest

I get

listing source files under version control: 11 files and directories
building an sdist: check-manifest-0.22.dev0.tar.gz: 10 files and directories
copying source files to a temporary directoryTraceback (most recent call last):
  File "/home/mg/.venv/bin/check-manifest", line 11, in <module>
    sys.exit(main())
  File "/home/mg/.venv/local/lib/python2.7/site-packages/check_manifest.py", line 685, in main
    update=args.update, python=args.python):
  File "/home/mg/.venv/local/lib/python2.7/site-packages/check_manifest.py", line 598, in check_manifest
    copy_files(source_files, tempsourcedir)
  File "/home/mg/.venv/local/lib/python2.7/site-packages/check_manifest.py", line 184, in copy_files
    shutil.copy2(filename, destfile)
  File "/usr/lib/python2.7/shutil.py", line 130, in copy2
    copyfile(src, dst)
  File "/usr/lib/python2.7/shutil.py", line 82, in copyfile
    with open(src, 'rb') as fsrc:
IOError: [Errno 2] No such file or directory: u'MANIFEST.in'
mgedmin added a commit that referenced this issue Oct 1, 2014
This produces some nonsensical warnings, e.g.

    listing source files under version control: 11 files and directories
    building an sdist: check-manifest-0.22.dev0.tar.gz: 10 files and directories
    some files listed as being under source control are missing:
      LICENCE.rst
    copying source files to a temporary directory
    building a clean sdist: check-manifest-0.22.dev0.tar.gz: 10 files and directories
    files in version control do not match the sdist!
    missing from sdist:
      LICENCE.rst
    suggested MANIFEST.in rules:
      include *.rst

No, stupid computer, adding 'include *.rst' to MANIFEST.in is definitely
not going to help resurrect deleted files.
@mgedmin mgedmin closed this as completed Oct 1, 2014
mgedmin added a commit that referenced this issue Jan 30, 2015
This makes it behave the same way as with Git, and makes tests failed
with FORCE_TEST_VCS=hg.

AFAICT the original bug (#32) never affected Mercurial repositories, so
the user-visible change is merely cosmetic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant