Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Config to ignore bad_ideas #67

Closed
gregory-marton opened this issue Feb 25, 2016 · 2 comments
Closed

Config to ignore bad_ideas #67

gregory-marton opened this issue Feb 25, 2016 · 2 comments

Comments

@gregory-marton
Copy link

I have a case where a submodule not under my control has a bad_idea (an autogenerated file in VCS). I would like to be able to use check-manifest as part of an acceptance test suite, but there seems to be no way to tell it to just grumble silently and ignore this one file. Would you welcome a patch that created an option similar to ignore for this, perhaps named ignore_bad_ideas? Is there some easy workaround?
@gregory-marton gregory-marton mentioned this issue Feb 25, 2016
Closed
@mgedmin
Copy link
Owner

mgedmin commented Feb 28, 2016

That sounds like a good idea.

It'll also help with #38.

@brechtm
Copy link
Contributor

brechtm commented Aug 11, 2016

Is there any progress with respect to this issue? Thanks.

brechtm added a commit to brechtm/check-manifest that referenced this issue Aug 11, 2016
@brechtm
Accept a list of bad idea file patterns to ignore
eb1504d 
- new command line option --ignore-bad-ideas wich takes a list of
  patterns like --ignore.
- new config section 'ignore-bad-ideas' similar to 'ignore'

Closes mgedmin#67
@brechtm brechtm mentioned this issue Aug 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mgedmin @brechtm @gregory-marton