Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: deny missing_debug_implementations #95

Merged
merged 1 commit into from
Sep 30, 2017
Merged

lib: deny missing_debug_implementations #95

merged 1 commit into from
Sep 30, 2017

Conversation

mgeisler
Copy link
Owner

This lint will ensure that all public types implement Debug, which in
turn makes them much more user friendly since they can be formatted
using {:?}.

@hcpl
Copy link
Contributor

hcpl commented Sep 19, 2017

Debug impl for CharIndices appeared in Rust 1.9 (relevant PR: rust-lang/rust#32054, specifically for CharIndices here).

@mgeisler
Copy link
Owner Author

Thanks @hcpl -- perhaps it's time to bump the oldest supported Rust version then...

This lint will ensure that all public types implement Debug, which in
turn makes them much more user friendly since they can be formatted
using {:?}.
@mgeisler
Copy link
Owner Author

I ended up writing small Display implementations that ignore the CharIndices. I think that'll be good enough.

@hcpl
Copy link
Contributor

hcpl commented Sep 30, 2017

I'm sure this can be done better (e.g. for pretty-printing purposes) using DebugStruct - coming up with a PR right now!

@mgeisler mgeisler deleted the derive-debug branch March 31, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants