refactor(http/server): better io.Writer from logger

mgjules · Apr 11, 2022 · c75f265 · c75f265
1 parent fc64bb3
commit c75f265
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/http/server.go b/http/server.go
@@ -16,6 +16,7 @@ import (
 	"github.com/gin-gonic/gin"
 	"go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin"
 	"go.uber.org/fx"
+	"go.uber.org/zap"
 )
 
 const (
@@ -56,8 +57,10 @@ func NewServer(
 		gin.SetMode(gin.ReleaseMode)
 	}
 
-	gin.DefaultWriter = logger
-	gin.DefaultErrorWriter = logger
+	writer := zap.NewStdLog(logger.Desugar().Logger).Writer()
+
+	gin.DefaultWriter = writer
+	gin.DefaultErrorWriter = writer
 
 	s := Server{
 		router: gin.Default(),

diff --git a/logger/logger.go b/logger/logger.go
@@ -46,9 +46,3 @@ func New(lc fx.Lifecycle, cfg *config.Config) (*Logger, error) {
 
 	return &Logger{otellogger.Sugar()}, nil
 }
-
-func (l *Logger) Write(p []byte) (n int, err error) {
-	l.Debug(string(p))
-
-	return len(p), nil
-}