Replace nptyping with numpy.typing #154
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152, #153
I replaced
nptyping
NDArray occurrences withnumpy.typing
ones.I am not sure if it's possible to specify shape restrictions without forcing the package to require
python>=3.9
so that type subscription is available and things likenp.ndarray[Literal[1], np.dtype[Any]]
can be declared.Note that
numpy.typing.NDArray
is a type alias fornp.ndarray[Any, np.dtype[+ScalarType]]
whereScalarType
contains the following types:Although it is simpler to use it as it is, please let me know if a more permissible
NDArray[Any]
is preferred.