Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reaper will delete locks for running jobs #488

Closed
yaoyi opened this issue Apr 5, 2020 · 2 comments · Fixed by #493
Closed

Reaper will delete locks for running jobs #488

yaoyi opened this issue Apr 5, 2020 · 2 comments · Fixed by #493
Assignees
@mhenrixon
Labels
bug master v7.x

Comments

@yaoyi
Copy link

yaoyi commented Apr 5, 2020 •
edited
Loading

Describe the bug
we currently have many long-running jobs, which may take 10 - 60 minutes each, and use until_executed lock, but reaper cleans up locks for running jobs, and allow same jobs enqueued, and this also blocks the reaping for real orphans

Expected behavior
same jobs should not be enqueued after reaping
reaper should not clean up the locks for any running jobs if the lock type is while_executing or until_executed
@mhenrixon mhenrixon self-assigned this Apr 5, 2020
@mhenrixon
Copy link
Owner

Oof, I think it is a little more complicated than that. I believe we need to check if the job is checked out by any worker and if so skip cleaning the job.

Think that’s what is missing.

mhenrixon added a commit that referenced this issue Apr 8, 2020
@mhenrixon
Prevent reaping of active jobs
0ec52ae 
Close #488
@mhenrixon mhenrixon mentioned this issue Apr 8, 2020
Merged
mhenrixon added a commit that referenced this issue Apr 8, 2020
@mhenrixon
Prevent reaping of active jobs (#493)
16764fe 
* Begin prevention of reaping active jobs

* Prevent reaping of active jobs

Close #488

* Don't reek

* Mandatory rubocop commit
@mhenrixon
Copy link
Owner

Released as v7.0.15

@mhenrixon mhenrixon mentioned this issue Apr 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhenrixon mhenrixon

Labels
bug master v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent reaping of active jobs mhenrixon/sidekiq-unique-jobs
2 participants
@mhenrixon @yaoyi