Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on Sidekiq's String#constantize extension instead of rolling our own #19

Merged

Conversation

disbelief
Copy link
Contributor

As per discussion on issue #17, I've dropped the custom implementation of
String.constantize in favour of using the built-in Sidekiq implementation.

Currently this helper method behaves the same as it did previously, if the
string could not be constantized, no exception is raised, and the original
string argument is returned.

Note that calling klass.get_sidekiq_options on the next line of call is
going to raise an exception anyway if klass is a string.

mhenrixon added a commit that referenced this pull request Aug 28, 2013
…dleware

Rely on Sidekiq's String#constantize extension instead of rolling our own
@mhenrixon mhenrixon merged commit 098c20e into mhenrixon:master Aug 28, 2013
@mhenrixon
Copy link
Owner

Love it, thanks for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants