Rely on Sidekiq's String#constantize extension instead of rolling our own #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion on issue #17, I've dropped the custom implementation of
String.constantize in favour of using the built-in Sidekiq implementation.
Currently this helper method behaves the same as it did previously, if the
string could not be constantized, no exception is raised, and the original
string argument is returned.
Note that calling
klass.get_sidekiq_options
on the next line ofcall
isgoing to raise an exception anyway if
klass
is a string.