Ensure limit and timeout are always numbers

[pinkahd]

This should prevent errors where a string is passed
as the lock_timeout or lock_limit and .positive?
is called.

[mhenrixon]

I don't understand how a string can enter there. I'm not super fond of this but if it solves a problem for you I don't mind terribly.

To my knowledge, you'd have to configure like this:

sidekiq_options lock_limit: "2", lock_timeout: "5"

I would like to validate against this and raise a helpful message if that's the case.

[pinkahd]

I don't understand how a string can enter there. I'm not super fond of this but if it solves a problem for you I don't mind terribly.

To my knowledge, you'd have to configure like this:

sidekiq_options lock_limit: "2", lock_timeout: "5"

I would like to validate against this and raise a helpful message if that's the case.

I'm not 100% sure as well this is our configuration for the job in question 👇🏼 what might happen is the fact that we use Sidekiq 5.2.9 or an older version or Redis 🤔

class SomeWorkerWorker
  sidekiq_options queue: :important, lock: :until_executed, lock_timeout: 1.minute, retry: false
  
  def perform(some_arg_id)
    ...
  end
end

But we're still seeing errors such as:

undefined method `positive?' for "60":String

My guess is that somehow Sidekiq serialises the options as strings instead of numbers 🤔

[mhenrixon]

Super weird, thank you for the detailed explanation. I'll cut a new version