Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #617
There is an issue where an integer
config.timeout
was beingrespected in
pop_queued
, but the promise inprimed_async
was onlywaiting the
config.ttl
plus the drift.This means that high latency redis connections will return a
nil
primed_jid
and while_executing jobs will get dropped.The proposed solution is to ensure that
config.timeout
gets passed inas the
wait
argument to the boundmethod(:primed_async)
, whichallows the
Concurrent::Promises
to timeout after the same duration(plus drift) as the
brpoplpush
call.The issue triage and approach is documented in: