Remove unnecessary log messages #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhenrixon
added a commit
that referenced
this pull request
Dec 18, 2012
Remove unnecessary log messages
|
Good catch! |
|
Thanks Mikael Sent from my iPhone On 2012-12-18, at 15:30, Mikael Henriksson notifications@github.com wrote: Good catch! — |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The information logging of the message contents in this plugin are redundant and cause excess log messages in production. I have removed them in this PR. Alternative would be to have them as debug messages, in which case I would suggest identifying them as coming from UniqueJobs Plugin. Since the plugin chain is called regardless of whether a workers uses this plugin, the log message appears for every job, regardless.