Checking Sidekiq::Testing.inline? on testing strategy and connector #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhenrixon
added a commit
that referenced
this pull request
Feb 24, 2015
…e_inline Checking Sidekiq::Testing.inline? on testing strategy and connector
|
Just a note, since unique jobs uses redis to lock/unlock jobs and gets the connection through sidekiq, the tests involving classes with Not sure if this should be in readme or something. I believe to completely remove this issue, unique jobs should implement a strategy that doesn't actually use redis when inline testing is being used (the same way sidekiq does it). |
|
I needed this patch to get things working without having to modify my test suite – a point release would be great so I don't have to use master! @mhenrixon (All in all, is it really worth the trouble using mock_redis? Especially since Sidekiq itself has other strategies for isolating tests.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking the testing strategy's
eligible?method theSidekiq::Testing.inline?was being checked, but not on the testing connector.This caused mock_redis to be required even when inline testing was not being used.
Should fix #71