This repository has been archived by the owner on Nov 19, 2024. It is now read-only.
remove probable existing symbolic link #139
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
reviewed
Jan 16, 2019
archiver.go
Outdated
| @@ -310,6 +310,7 @@ func writeNewSymbolicLink(fpath string, target string) error { | |||
| if err != nil { | |||
| return fmt.Errorf("%s: making directory for file: %v", fpath, err) | |||
| } | |||
| os.Remove(fpath) | |||
There was a problem hiding this comment.
We should only remove it if it's a symbolic link, right? Not safe to overwrite existing files with actual content.
Also might need to honor the various OverwriteExisting parameters for each archiver, for example, zip's:
Line 25 in d8fc61a
There was a problem hiding this comment.
@mholt Please consider new changes.
Now zip and tar archives which currently use writeNewSymbolicLink method, use their OverwriteExisting to remove existing symbolic links safely.
|
I believe #302 makes this irrelevant -- thank you for the contribution. Sorry I never got around to finishing it with you. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some extracting situations that an archive contains a symbolic link file,
archiver tries to create a symbolic link, but already the symbolic file
exists and it causes the
file existserror. This commit adds a blindremoving try: if the symbolic link already exists (from extraction process),
remove it and if does not, ignore the returned error.