Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ic-badge] Dark mode info variant icons are showing as the wrong colour #2910

Open
GCHQ-Developer-530 opened this issue Dec 17, 2024 · 0 comments
Assignees
Labels
type: bug 🐛 Something isn't working
Milestone

Comments

@GCHQ-Developer-530
Copy link
Contributor

Summary of the bug

The dark mode token for info variant badges is wrong when there is an icon. The text variant is showing correctly in black, but the icon is showing as white.

📸 Screenshots or code

badge-icon-wrong-colour

🧐 Expected behaviour

It should be updated to have a black icon for info badges in dark mode.

Additional info

Why has this not been picked up by Cypress tests? Do we need to add more tests for dark mode?

@GCHQ-Developer-530 GCHQ-Developer-530 added the type: bug 🐛 Something isn't working label Dec 17, 2024
@MI6-255 MI6-255 added this to the PI 10 V3 milestone Dec 19, 2024
@GCHQ-Developer-530 GCHQ-Developer-530 self-assigned this Dec 19, 2024
@GCHQ-Developer-530 GCHQ-Developer-530 moved this from Ready for dev to Dev In Progress in Intelligence Community Design System Dec 19, 2024
GCHQ-Developer-530 added a commit that referenced this issue Dec 19, 2024
Update icon colours for dark mode badge to match the text colour of badges in dark mode

. #2910
@GCHQ-Developer-530 GCHQ-Developer-530 moved this from Dev In Progress to In Review in Intelligence Community Design System Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Status: In Review
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants