Theme from context fix #2929
Merged
Theme from context fix #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ckground fixes components that are displayed on brand coloured background
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/theme-from-context-fix/web-components |
fixes components that are displayed on brand coloured background
ad9242
force-pushed
the
theme-from-context-fix
branch
2 times, most recently
from
fe0662b to
0b238aa
Compare
fixes components that are displayed on brand coloured background
ad9242
force-pushed
the
theme-from-context-fix
branch
from
fa41dcc to
2f7677b
Compare
GCHQ-Developer-530
approved these changes
Dec 19, 2024
GCHQ-Developer-299
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
Fixes issues with display of components on a brand coloured background (eg hero, top nav etc)
This reverses some changes to the method made in a previous PR, hence changes to unit tests
Also removes the need to pass theme to components placed on hero etc
Related issue
N/A