All flags redeemed #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miallo
force-pushed
the
all-flags-redeemed
branch
from
049d9d5 to
604b63c
Compare
since we need to keep the CREDIT_WHERE_CREDIT_IS_DUE in sync with the rest of the code of redeem.nuggit and we could not do a good obfuscation any ways, we just inline the checks again... Note that we also now have to adapt the checks for the number of nuggits to account for the off-by-one error from the dupicate
In addition to the nuggit "branch" we write this check with the number of redeemed nuggits (not technically needed any more, but we can use it to detect if someone just adds new commits to that "branch")
miallo
force-pushed
the
all-flags-redeemed
branch
from
1405f33 to
d3d2f3f
Compare
test: repeeted redeeming should still show "You almost got it!"
miallo
force-pushed
the
all-flags-redeemed
branch
from
7a23a9e to
8745c58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.