Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newest .net #19

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Update to newest .net #19

merged 5 commits into from
Aug 27, 2024

Conversation

sensslen
Copy link
Contributor

No description provided.

@micdenny
Copy link
Owner

thank you for this contribution, please have a check of the failed build

@sensslen
Copy link
Contributor Author

sorry - fixed

@micdenny
Copy link
Owner

removing netcoreapp3.1 and net5 support do you think it's better to bump the version to a major release 3.0.0?

@sensslen
Copy link
Contributor Author

I would not think so - netcoreapp3.1 is out of support as well as net5.... However it's up to you to decide...

@micdenny
Copy link
Owner

In fact I didn't change any part of the public surface nor internal feature, so basically the new version is just for updating target frameworks.

I will bump the patch then, because I didn't change any feature.

@micdenny micdenny merged commit 332e706 into micdenny:master Aug 27, 2024
1 check passed
@micdenny
Copy link
Owner

deployed to nuget, will be ready soon: https://www.nuget.org/packages/WpfScreenHelper/2.1.1

@sensslen
Copy link
Contributor Author

Thanks you a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants