patched code #156
Open
patched code #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to set the height either by option or for the multi select to discover the height of the container that it is rendering in and accounting the height of sibling elements.
updated the css to hide overflowing options
I have observed a bug where the 'is' method is not identifying selected options because the 'selected' attribute was not set.
Update to adjust the menu to fit the content that is to be shown. reason sometimes the button is 75px in width but the content is 300 pixels or in multi select mode for the header to look nice it needs to be minumum 225 pixels wide.
some widgets like jq grid offer frozen columns which basically clones the selected columns and headers from the main layer and fixes them at a relative position to give the impression of being frozen. however this code was always referencing the button of the original layer that was scrollable. as a consequence the drop down would not appear where a user would expect it to in this particular use case. This code change address's the issue by always using the button that was used to show the select list.
copy of my css for this widget
added the ability configure a means for the Ctrl changes to be canceled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have corrected my code fu pah and this is the code for this project with all my tweaks that were made to make better use of it in the jq grid widget and as a stand alone.