Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #425

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Update README.md #425

merged 3 commits into from
Nov 15, 2024

Conversation

LetsssGo55
Copy link
Contributor

Fixed some important grammatical error ,change the url Before
[https:///michaelfeil.github.io/infinity]
After
[https://michaelfeil.github.io/infinity/latest/]

Fixed some important grammatical error ,change the url 
Before
[https:///michaelfeil.github.io/infinity]
After
[https://michaelfeil.github.io/infinity/latest/]
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request updates the README.md file for the Infinity project, focusing on improving clarity and accuracy of the project documentation.

  • Updated documentation URL from 'https:///michaelfeil.github.io/infinity' to 'https://michaelfeil.github.io/infinity/latest/' for more precise navigation
  • Corrected 'torch' to 'PyTorch' for accurate library reference
  • Refined wording in the 'Tested implementation' section for better clarity
  • Fixed minor grammatical errors throughout the document

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@michaelfeil
Copy link
Owner

Bot pr?

@LetsssGo55
Copy link
Contributor Author

This is not bot Pull request.

@LetsssGo55
Copy link
Contributor Author

Can u merge it i think i have made valuable contribution.

@michaelfeil
Copy link
Owner

@LetsssGo55 You created github profile 4 weeks ago, and only add readme.
The contribution is incorrect, the link wrong.

I can't think of any other use case than gaming the GitHub permission system to be marked as "contributor" to "steal" e.g. secrets from the project settings.

@michaelfeil michaelfeil reopened this Nov 15, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

No major changes found since last review. The previous review already covered all the significant changes made to the README.md file, including the documentation URL update, PyTorch naming correction, and grammatical fixes.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@michaelfeil michaelfeil merged commit 774530b into michaelfeil:main Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants