Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

end-2-end faster tests #431

Merged
merged 2 commits into from
Oct 19, 2024
Merged

end-2-end faster tests #431

merged 2 commits into from
Oct 19, 2024

Conversation

michaelfeil
Copy link
Owner

No description provided.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This pull request focuses on improving end-to-end test performance and enhancing type hinting across multiple files in the infinity_emb library. Key changes include:

  • Added fallback definition for DataURIorURL in pymodels.py for cases when Pydantic is unavailable
  • Improved type hinting and mixed input handling in infinity_server.py
  • Consolidated test functions in test_torch_audio.py and test_torch_vision.py to reduce code duplication
  • Updated skip reasons for CTranslate2 tests on macOS in test_ct2_sentence.py
  • Simplified assertions in test_torch_classify.py by removing detailed result comparisons

These changes aim to streamline testing processes and improve type safety without affecting runtime performance.

6 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.22%. Comparing base (0a80dff) to head (d31af3f).

Files with missing lines Patch % Lines
...inity_emb/infinity_emb/fastapi_schemas/pymodels.py 0.00% 1 Missing ⚠️
libs/infinity_emb/infinity_emb/infinity_server.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   79.27%   79.22%   -0.05%     
==========================================
  Files          41       41              
  Lines        3242     3245       +3     
==========================================
+ Hits         2570     2571       +1     
- Misses        672      674       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil merged commit 6df448f into main Oct 19, 2024
36 checks passed
@michaelfeil michaelfeil deleted the end-2-end-tests-faster branch October 19, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants