Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update transformers package #471

Merged
merged 2 commits into from
Nov 18, 2024
Merged

update transformers package #471

merged 2 commits into from
Nov 18, 2024

Conversation

wirthual
Copy link
Collaborator

Related Issue

#470

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have added tests to cover my changes.
  • I have updated the documentation (docs folder) accordingly.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updates the transformers package minimum version requirement to fix compatibility with the NV-Embed-v2 model's LatentAttentionConfig implementation.

  • Changed transformers version constraint from '>4.34.0,<=5.0' to '>=4.46.2,<=5.0' in /libs/infinity_emb/pyproject.toml to resolve AttributeError with LatentAttentionConfig
  • Maintains upper bound compatibility with transformers 5.0 while ensuring minimum version supports newer attention implementations

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.51%. Comparing base (d2941c7) to head (b5b6a6e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
- Coverage   79.57%   79.51%   -0.06%     
==========================================
  Files          41       41              
  Lines        3417     3417              
==========================================
- Hits         2719     2717       -2     
- Misses        698      700       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil
Copy link
Owner

Not sure if all users are happy with bumping the mandatory version! Maybe just update the .lock file.

  • undo the changes on pyproject.toml
  • poetry lock —no-update

@wirthual
Copy link
Collaborator Author

Got it. Updated the lock file by running

poetry update transformers

Reverted pyproject.toml to the version on main branch.

@michaelfeil michaelfeil merged commit a9f9aac into main Nov 18, 2024
36 checks passed
@michaelfeil michaelfeil deleted the rw/update-transformers branch November 18, 2024 03:24
@michaelfeil
Copy link
Owner

Not sure if this makes nv-embed-2 work (https://huggingface.co/nvidia/NV-Embed-v2/blob/main/config.json) says transformer is 4.42.4, and this PR bumped 4.45 -> 4.46

@michaelfeil
Copy link
Owner

Maybe --no-bettertransformer is worth running for the NV-Embed

@wirthual
Copy link
Collaborator Author

Let me try that. However with the 0.45.2 version of the transformer package I got the error described in the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants