Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python classification example #487

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

molntamas
Copy link
Contributor

Argument was missing from the classifier function

Related Issue

None

-->

Checklist

  • [X ] I have read the CONTRIBUTING guidelines.
  • I have added tests to cover my changes.
  • [ X] I have updated the documentation (docs folder) accordingly.

Additional Notes

Only the documentation was edited.

Argument was mssing from classifier function
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added missing engine parameter to the classifier function example in README.md to properly demonstrate how to use the classification functionality with AsyncEmbeddingEngine.

  • Fixed code example in README.md by adding required engine parameter to classifier() function signature
  • Aligns documentation with actual implementation requirements for classification operations
  • Improves clarity for users implementing text classification with infinity

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.54%. Comparing base (bfb66fd) to head (709ade3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #487      +/-   ##
==========================================
+ Coverage   79.48%   79.54%   +0.05%     
==========================================
  Files          41       41              
  Lines        3422     3422              
==========================================
+ Hits         2720     2722       +2     
+ Misses        702      700       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelfeil michaelfeil merged commit 1973648 into michaelfeil:main Dec 3, 2024
36 checks passed
@michaelfeil
Copy link
Owner

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants