Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement account with seed in system program #101

Merged
merged 3 commits into from
Sep 20, 2021

Conversation

drbh
Copy link
Contributor

@drbh drbh commented Sep 19, 2021

@drbh
Copy link
Contributor Author

drbh commented Sep 19, 2021

@michaelhly please let me know if I should make any changes before merge

@kevinheavey
Copy link
Collaborator

kevinheavey commented Sep 19, 2021

I'm not a maintainer but you'll want to write a test for this in tests/unit/test_system_program.py. Should be simple to imitate an existing test

added a test and fixed syntax bug.
@drbh
Copy link
Contributor Author

drbh commented Sep 20, 2021

@kevinheavey thanks for the advice! I've added a unit test test_create_account_with_seed and implemented the decode_create_account_with_seed function that was missing from the original commit

@codecov
Copy link

codecov bot commented Sep 20, 2021

Codecov Report

Merging #101 (d1a3e08) into master (7bf0ee0) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   88.02%   88.14%   +0.12%     
==========================================
  Files          32       32              
  Lines        2130     2135       +5     
==========================================
+ Hits         1875     1882       +7     
+ Misses        255      253       -2     

@michaelhly
Copy link
Owner

Looks good. But you need to run make fmt. Thanks!

@michaelhly michaelhly merged commit c393121 into michaelhly:master Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants