Add max_retries option to sendTransaction and commitment option to get_transaction #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the method of send_transaction has missed the param of commitment, this param is useful because of the finalized time delay is greater than confirmed |
Codecov Report
@@ Coverage Diff @@
## master #165 +/- ##
==========================================
- Coverage 91.06% 90.89% -0.17%
==========================================
Files 37 37
Lines 2696 2702 +6
==========================================
+ Hits 2455 2456 +1
- Misses 241 246 +5 |
|
lint types fixed |
Can you also run |
michaelhly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the sendTransaction method in json rpc API has 4 params that: skipPreflight, preflightCommitment, encoding, maxRetries, but the master has only 3 params, I have add the last maxRetries param to the master