Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default to RPC client commitment in token client #187

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

kevinheavey
Copy link
Collaborator

For methods that take a commitment arg, default to using the RPC client commitment if this arg is None

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #187 (4918012) into master (dd2105a) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
- Coverage   91.11%   90.97%   -0.15%     
==========================================
  Files          39       39              
  Lines        2725     2726       +1     
==========================================
- Hits         2483     2480       -3     
- Misses        242      246       +4     

@kevinheavey kevinheavey merged commit 16e2642 into master Feb 11, 2022
@kevinheavey kevinheavey deleted the token-commitment branch February 11, 2022 22:02
@kevinheavey kevinheavey restored the token-commitment branch February 11, 2022 22:02
@kevinheavey kevinheavey deleted the token-commitment branch February 11, 2022 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant