Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use solders under the hood for keypairs and pubkeys #237

Merged
merged 14 commits into from
May 29, 2022

Conversation

kevinheavey
Copy link
Collaborator

Two minor breaking changes:

  • The optional nacl.public.PrivateKey in Keypair.__init__ is replaced with an optional solders.keypair.Keypair
  • Keypair.sign returns a solders Signature instead of nacl signing.SignedMessage

@codecov
Copy link

codecov bot commented May 28, 2022

Codecov Report

Merging #237 (40a00a8) into master (14c220e) will increase coverage by 0.02%.
The diff coverage is 96.29%.

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
+ Coverage   91.32%   91.35%   +0.02%     
==========================================
  Files          41       40       -1     
  Lines        2767     2717      -50     
==========================================
- Hits         2527     2482      -45     
+ Misses        240      235       -5     

@kevinheavey kevinheavey requested a review from michaelhly May 28, 2022 21:10
@kevinheavey kevinheavey merged commit cb80ad1 into master May 29, 2022
@kevinheavey kevinheavey deleted the solders-keypair branch May 29, 2022 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants