Use solders for Message #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 91.25% 91.09% -0.17%
==========================================
Files 38 38
Lines 2676 2638 -38
==========================================
- Hits 2442 2403 -39
- Misses 234 235 +1 |
michaelhly
approved these changes
May 29, 2022
| program_id_index=account_indices[str(instruction.program_id)], | ||
| data=b58encode(instruction.data), | ||
| data=instruction.data, |
There was a problem hiding this comment.
How come we don't have to encode base58 anymore?
There was a problem hiding this comment.
I actually don't know why we were doing it since the data was then being base58-decoded in __encode_instruction 🤷♂️ guessing this behaviour came from web3.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.