Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added memo with tests and verify_signature bool #249

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

crypt0miester
Copy link
Contributor

  • Added memo program with tests.
  • Added memo docs
  • Added verify signatures for transaction.serialize() since sometimes the frontend is the fee payer.
    This uses the same functionality as web3.js
  • Added unit test to make sure that the verify signature=False would work.

@crypt0miester crypt0miester mentioned this pull request Jun 7, 2022
@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #249 (1e1c413) into master (8969968) will increase coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   91.02%   91.11%   +0.08%     
==========================================
  Files          34       36       +2     
  Lines        2541     2565      +24     
==========================================
+ Hits         2313     2337      +24     
  Misses        228      228              

@michaelhly
Copy link
Owner

michaelhly commented Jun 9, 2022

@kevinheavey everything looks fine to you?

@kevinheavey
Copy link
Collaborator

Yeah lgtm

@kevinheavey kevinheavey merged commit 877c8dd into michaelhly:master Jun 9, 2022
@michaelhly michaelhly mentioned this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants